-
Notifications
You must be signed in to change notification settings - Fork 798
添加详细构建指南 #4524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
添加详细构建指南 #4524
Conversation
|
|
||
| ## 环境需求 | ||
|
|
||
| 构建 HMCL 启动器需要安装 JDK 17 (或更高版本)。你可以从此处下载它: [Download Liberica JDK](https://bell-sw.com/pages/downloads/#jdk-25-lts)。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
或许不用指定 #jdk-25-lts ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
附议。
3gf8jv4dv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive build guides for the HMCL launcher project by creating separate documentation files and updating the main README to reference them. The Chinese version has been implemented first, with other language translations planned after review.
Key Changes:
- Refactored build instructions into dedicated guide documents
- Added detailed environment setup and source code acquisition steps
- Updated build command from
gradlew clean buildtogradlew clean makeExecutables
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/README_zh.md | Simplified by replacing inline build instructions with a reference to the new detailed build guide |
| docs/Building_zh.md | New Chinese build guide with JDK requirements, environment setup, source code acquisition, and build instructions |
| docs/Building.md | New English build guide with identical content structure as the Chinese version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
目前只写了中文版本,在讨论修订完成后会翻译至其他语言。